Enable React transform option throwIfNamespace #8204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
turbo-orchestrator
bot
added
needs: triage
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @timneutkens and the rest of your teammates on |
kdy1
approved these changes
May 23, 2024
🟢 Turbopack Benchmark CI successful 🟢Thanks |
arlyon
approved these changes
May 23, 2024
|
✅ This change can build |
|
kdy1
reviewed
Jul 1, 2024
There was a problem hiding this comment.
throw_if_namespace is true by default.
https://rustdoc.swc.rs/src/swc_ecma_transforms_react/jsx/mod.rs.html#183-226
kdy1
approved these changes
Jul 1, 2024
mischnic
deleted the
05-23-enable_react_transform_option_throwifnamespace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Matches behavior in Next.js: https://github.com/vercel/next.js/blob/b735c3b1ffcc482a26579ef51b9e2144db74c858/packages/next/src/build/swc/options.ts#L134
Testing Instructions